azagrebin commented on a change in pull request #8496: [FLINK-12571][network]
Make NetworkEnvironment#start() return the binded data port
URL: https://github.com/apache/flink/pull/8496#discussion_r288189245
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/NetworkEnvironment.java
##########
@@ -275,15 +276,15 @@ private void registerInputMetrics(MetricGroup
inputGroup, MetricGroup buffersGro
buffersGroup.gauge(METRIC_INPUT_POOL_USAGE, new
InputBufferPoolUsageGauge(inputGates));
}
- public void start() throws IOException {
+ public int start() throws IOException {
Review comment:
Let's have a doc comment for this method in particular about the return
value, also in the `ConnectionManager` interface
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
