bowenli86 commented on a change in pull request #8564: [FLINK-12649][hive] Add a shim layer to support multiple versions of HMS URL: https://github.com/apache/flink/pull/8564#discussion_r288686542
########## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/HiveShim.java ########## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.catalog.hive; + +import org.apache.hadoop.hive.conf.HiveConf; +import org.apache.hadoop.hive.metastore.IMetaStoreClient; +import org.apache.hadoop.hive.metastore.api.Function; +import org.apache.hadoop.hive.metastore.api.NoSuchObjectException; +import org.apache.hadoop.hive.metastore.api.UnknownDBException; +import org.apache.thrift.TException; + +import java.util.List; + +/** + * A shim layer to support different versions of HMS. + */ +public interface HiveShim { + + /** + * Create a Hive Metastore client based on the given HiveConf object. + * + * @param hiveConf HiveConf instance + * @return an IMetaStoreClient instance + */ + IMetaStoreClient getHiveMetastoreClient(HiveConf hiveConf); + + /** + * Get a list of views in the given database from the given Hive Metastore client. + * + * @param client Hive Metastore client + * @param databaseName the name of the database + * @return A list of names of the views + * @throws UnknownDBException TException Review comment: `TException` should be replaced with an explanation of `UnknownDBException`. rewrite the javadoc, and add `@throws TException xxx`? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
