bowenli86 commented on a change in pull request #8564: [FLINK-12649][hive] Add 
a shim layer to support multiple versions of HMS
URL: https://github.com/apache/flink/pull/8564#discussion_r289257720
 
 

 ##########
 File path: flink-connectors/flink-connector-hive/pom.xml
 ##########
 @@ -423,4 +423,22 @@ under the License.
                        </plugin>
                </plugins>
        </build>
+
+       <profiles>
+               <profile>
+                       <id>hive-1</id>
+                       <properties>
+                               <hive.version>1.2.1</hive.version>
+                               
<hivemetastore.hadoop.version>2.6.0</hivemetastore.hadoop.version>
+                       </properties>
+                       <dependencies>
+                               <dependency>
 
 Review comment:
   it's excluded because it's not used previously. I think we can remove this 
as well as the exclusion of it in hive-metastore. I will have open a followup 
PR to make hive-metastore 'provided'

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to