xuefuz commented on a change in pull request #8522: 
[FLINK-12572][hive]Implement TableSource and InputFormat to read Hive tables
URL: https://github.com/apache/flink/pull/8522#discussion_r288804130
 
 

 ##########
 File path: 
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/util/HiveTableUtil.java
 ##########
 @@ -71,4 +85,69 @@ public static TableSchema 
createTableSchema(List<FieldSchema> cols, List<FieldSc
 
                return columns;
        }
+
+       /**
+        * Convert partition value string to actual type in flink.
+        * @param partitionValue
+        * @param clazz
+        * @return
+        */
+       //todo: check whether hive partition field can be decimal or not .
+       public static Object getActualObjectFromString(String partitionValue, 
Class clazz) {
 
 Review comment:
   Maybe we can have a more meaningful method name, like 
getPartitionValueOjectFromString.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to