Myasuka commented on a change in pull request #8571: [FLINK-12682][connectors]
StringWriter support custom row delimiter
URL: https://github.com/apache/flink/pull/8571#discussion_r288934850
##########
File path:
flink-connectors/flink-connector-filesystem/src/main/java/org/apache/flink/streaming/connectors/fs/StringWriter.java
##########
@@ -54,13 +57,15 @@ public StringWriter() {
*
* @param charsetName Name of the charset to be used, must be valid
input for {@code Charset.forName(charsetName)}
*/
- public StringWriter(String charsetName) {
+ public StringWriter(String charsetName,byte[] rowDelimiter ) {
Review comment:
If we have already provided the `charsetName`, why not just provided the
`String` `delimiter` as parameter and the use `delimiter.getBytes(charsetName)`
to get the target bytes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
