azagrebin commented on a change in pull request #8566: [FLINK-12673][network] 
Introduce NetworkEnvironment.getUnreleasedPartitions instead of using 
getResultPartitionManager
URL: https://github.com/apache/flink/pull/8566#discussion_r288952426
 
 

 ##########
 File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/NetworkEnvironment.java
 ##########
 @@ -201,6 +203,28 @@ public void 
releasePartitions(Collection<ResultPartitionID> partitionIds) {
                }
        }
 
+       /**
+        * Report unreleased partitions.
+        *
+        * <p>Partitions are released in the following cases:
 
 Review comment:
   This is mostly a prep step for introducing a shuffle service interface, it 
is not intended only for netty implementation. We can think where it belongs 
when the interface is introduced. I would keep it here now because it is mostly 
relevant here atm to understand what is unreleased.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to