zhijiangW commented on a change in pull request #8362: [FLINK-11391] Introduce shuffle master interface URL: https://github.com/apache/flink/pull/8362#discussion_r289273088
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/shuffle/NettyShuffleDescriptor.java ########## @@ -0,0 +1,129 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.shuffle; + +import org.apache.flink.runtime.clusterframework.types.ResourceID; +import org.apache.flink.runtime.io.network.ConnectionID; +import org.apache.flink.runtime.io.network.partition.ResultPartitionID; + +import javax.annotation.Nonnegative; + +import java.io.Serializable; +import java.net.InetAddress; +import java.net.InetSocketAddress; + +/** + * Default implementation of {@link ShuffleDescriptor} for {@link NettyShuffleMaster}. + */ +public class NettyShuffleDescriptor implements ShuffleDescriptor { + + private static final long serialVersionUID = 852181945034989215L; + + private final ResourceID producerResourceID; + + private final PartitionLocation producerLocation; + + + private final ResultPartitionID resultPartitionID; + + public NettyShuffleDescriptor( + ResourceID producerResourceID, + PartitionLocation producerLocation, + ResultPartitionID resultPartitionID) { + this.producerResourceID = producerResourceID; + this.producerLocation = producerLocation; + this.resultPartitionID = resultPartitionID; + } + + public ConnectionID getConnectionId() { + return producerLocation.getConnectionId(); + } + + @Override + public ResultPartitionID getResultPartitionID() { + return resultPartitionID; + } + + public boolean isLocalTo(ResourceID consumerResourceId) { + return producerResourceID.equals(consumerResourceId); + } + + /** + * Location of partition producer used to connect to it for shuffle exchange. + */ + public interface PartitionLocation extends Serializable { + ConnectionID getConnectionId(); + } + + /** + * Remote location of producer with index to query partition. + * + * <p>Normal producer location with network address and port for connection. + */ + public static class RemotePartitionLocation implements PartitionLocation { + + private static final long serialVersionUID = 5992534320110743746L; + + /** Connection index to identify this partition of intermediate result. */ + private final int connectionIndex; + + /** The address to connect to the producer. */ + private final InetAddress address; + + /** + * The port to connect to the producer for shuffle exchange. + */ + @Nonnegative + private final int dataPort; + + public RemotePartitionLocation(int connectionIndex, InetAddress address, @Nonnegative int dataPort) { Review comment: @VisibleForTesting ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
