zhijiangW commented on a change in pull request #8362: [FLINK-11391] Introduce
shuffle master interface
URL: https://github.com/apache/flink/pull/8362#discussion_r289277305
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/deployment/ResultPartitionDeploymentDescriptor.java
##########
@@ -39,99 +37,59 @@
private static final long serialVersionUID = 6343547936086963705L;
- /** The ID of the result this partition belongs to. */
- private final IntermediateDataSetID resultId;
-
- /** The ID of the partition. */
- private final IntermediateResultPartitionID partitionId;
+ private final PartitionDescriptor partitionDescriptor;
- /** The type of the partition. */
- private final ResultPartitionType partitionType;
+ private final ShuffleDescriptor shuffleDescriptor;
- /** The number of subpartitions. */
- private final int numberOfSubpartitions;
-
- /** The maximum parallelism. */
private final int maxParallelism;
/** Flag whether the result partition should send
scheduleOrUpdateConsumer messages. */
private final boolean sendScheduleOrUpdateConsumersMessage;
public ResultPartitionDeploymentDescriptor(
- IntermediateDataSetID resultId,
- IntermediateResultPartitionID partitionId,
- ResultPartitionType partitionType,
- int numberOfSubpartitions,
- int maxParallelism,
- boolean lazyScheduling) {
-
- this.resultId = checkNotNull(resultId);
- this.partitionId = checkNotNull(partitionId);
- this.partitionType = checkNotNull(partitionType);
-
+ PartitionDescriptor partitionDescriptor,
+ ShuffleDescriptor shuffleDescriptor,
+ int maxParallelism,
+ boolean sendScheduleOrUpdateConsumersMessage) {
Review comment:
Add one empty line or one more indention for above parameters
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
