zhijiangW commented on a change in pull request #8362: [FLINK-11391] Introduce 
shuffle master interface
URL: https://github.com/apache/flink/pull/8362#discussion_r289725293
 
 

 ##########
 File path: 
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/consumer/SingleInputGateTest.java
 ##########
 @@ -642,4 +650,13 @@ static void verifyBufferOrEvent(
                        
assertFalse(inputGate.pollNextBufferOrEvent().isPresent());
                }
        }
+
+       private static PartitionInfo createPartitionInfo(ResultPartitionID id, 
ResourceID location) {
+               ShuffleDescriptor shuffleDescriptor = 
NettyShuffleDescriptorBuilder
 
 Review comment:
   `createRemoteWithIdAndLocation(id.getPartitionId(), location)` instead?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to