zhijiangW commented on a change in pull request #8362: [FLINK-11391] Introduce
shuffle master interface
URL: https://github.com/apache/flink/pull/8362#discussion_r289739240
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskTest.java
##########
@@ -271,33 +273,43 @@ public void testExecutionFailsInBlobsMissing() throws
Exception {
@Test
public void testExecutionFailsInNetworkRegistrationForPartitions()
throws Exception {
+ PartitionDescriptor partitionDescriptor = new
PartitionDescriptor(
+ new IntermediateDataSetID(),
+ new IntermediateResultPartitionID(),
+ ResultPartitionType.PIPELINED,
+ 1,
+ 1);
+ ShuffleDescriptor shuffleDescriptor =
NettyShuffleDescriptorBuilder.newBuilder().buildLocal();
ResultPartitionDeploymentDescriptor dummyPartition = new
ResultPartitionDeploymentDescriptor(
- new IntermediateDataSetID(), new
IntermediateResultPartitionID(),
- ResultPartitionType.PIPELINED, 1, 1, true);
+ partitionDescriptor,
+ shuffleDescriptor,
+ 1,
+ false);
testExecutionFailsInNetworkRegistration(Collections.singleton(dummyPartition),
Collections.emptyList());
}
@Test
public void testExecutionFailsInNetworkRegistrationForGates() throws
Exception {
- InputChannelDeploymentDescriptor dummyChannel =
- new InputChannelDeploymentDescriptor(new
ResultPartitionID(), ResultPartitionLocation.createLocal());
+ ShuffleDescriptor dummyChannel =
NettyShuffleDescriptorBuilder.newBuilder().buildRemote();
InputGateDeploymentDescriptor dummyGate = new
InputGateDeploymentDescriptor(
- new IntermediateDataSetID(),
ResultPartitionType.PIPELINED, 0,
- new InputChannelDeploymentDescriptor[] { dummyChannel
});
+ new IntermediateDataSetID(),
+ ResultPartitionType.PIPELINED,
+ 0,
+ new ShuffleDescriptor[] { dummyChannel },
+ ResourceID.generate());
testExecutionFailsInNetworkRegistration(Collections.emptyList(),
Collections.singleton(dummyGate));
}
private void testExecutionFailsInNetworkRegistration(
- Collection<ResultPartitionDeploymentDescriptor>
resultPartitions,
- Collection<InputGateDeploymentDescriptor> inputGates) throws
Exception {
+ Collection<ResultPartitionDeploymentDescriptor>
resultPartitions,
+ Collection<InputGateDeploymentDescriptor> inputGates)
throws Exception {
+ String errorMessage = "Network buffer pool has already been
destroyed.";
Review comment:
not necessary changes for this method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
