zhijiangW commented on a change in pull request #8529: [FLINK-12603][network]
Remove getOwningTaskName method from InputGate
URL: https://github.com/apache/flink/pull/8529#discussion_r289872280
##########
File path: flink-core/src/main/java/org/apache/flink/api/common/TaskInfo.java
##########
@@ -67,11 +56,12 @@ public TaskInfo(
checkArgument(indexOfSubtask < numberOfParallelSubtasks, "Task
index must be less than parallelism.");
checkArgument(attemptNumber >= 0, "Attempt number must be a
non-negative number.");
this.taskName = checkNotNull(taskName, "Task Name must not be
null.");
+ this.taskNameWithSubtasks = checkNotNull(taskNameWithSubtasks);
+ this.taskNameWithSubtaskAndID =
checkNotNull(taskNameWithSubtaskAndID);
Review comment:
Yes, that is another option, but that would cause generate this task name
multiple times for `BarrierBuffer` and `StreamProcessor`. The benefit of
generating task name in `TaskInfo` is that it is done only once and be reused
for all the places. If we further extend to reuse this name in other components
we also do not need to generate it again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
