zhijiangW commented on a change in pull request #8529: [FLINK-12603][network] 
Remove getOwningTaskName method from InputGate
URL: https://github.com/apache/flink/pull/8529#discussion_r289875446
 
 

 ##########
 File path: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/OneInputStreamTask.java
 ##########
 @@ -88,7 +88,8 @@ public void init() throws Exception {
                                        getStreamStatusMaintainer(),
                                        this.headOperator,
                                        
getEnvironment().getMetricGroup().getIOMetricGroup(),
-                                       inputWatermarkGauge);
+                                       inputWatermarkGauge,
+                                       
getEnvironment().getTaskInfo().getTaskNameWithSubtaskAndID());
 
 Review comment:
   Yes, that could also work. The only concern is we need do this multiple 
times in different components which need task name. Actually I think the task 
name with different info should belong to the scope of `TaskInfo` if we are 
caring about the previous implementation limit. WDYT?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to