dianfu commented on a change in pull request #8561: [FLINK-12588][python] Add
TableSchema for Python Table API.
URL: https://github.com/apache/flink/pull/8561#discussion_r290198065
##########
File path: flink-python/pyflink/table/table_descriptor.py
##########
@@ -287,6 +300,19 @@ def line_delimiter(self, delimiter):
self._j_csv = self._j_csv.lineDelimiter(delimiter)
return self
+ def schema(self, schema):
Review comment:
What about changing the argument name to `table_schema` to be consistent
with the method `Schema.schema`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
