dianfu commented on a change in pull request #8561: [FLINK-12588][python] Add
TableSchema for Python Table API.
URL: https://github.com/apache/flink/pull/8561#discussion_r290277452
##########
File path: flink-python/pyflink/table/types.py
##########
@@ -1737,15 +1966,15 @@ def DOUBLE(cls, nullable=True):
@classmethod
def DATE(cls, nullable=True):
- return DateType(nullable)
+ return DateType(nullable).bridged_to("java.sql.Date")
@classmethod
def TIME(cls, precision=0, nullable=True):
- return TimeType(precision, nullable)
+ return TimeType(precision, nullable).bridged_to("java.sql.Time")
@classmethod
- def TIMESTAMP(cls, kind=TimestampKind.REGULAR, precision=6, nullable=True):
- return TimestampType(kind, precision, nullable)
+ def TIMESTAMP(cls, kind=TimestampKind.REGULAR, precision=3, nullable=True):
Review comment:
Revert this change?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
