carp84 commented on a change in pull request #8617:
[FLINK-12619][StateBackend]Support TERMINATE/SUSPEND Job with Checkpoint
URL: https://github.com/apache/flink/pull/8617#discussion_r290567794
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/LegacyScheduler.java
##########
@@ -624,4 +624,58 @@ public void declineCheckpoint(final DeclineCheckpoint
decline) {
return savepointFuture.thenCompose((path) ->
terminationFuture.thenApply((jobStatus -> path)));
}
+
+ @Override
+ public CompletableFuture<String> stopWithCheckpoint(boolean
advanceToEndOfEventTime) {
Review comment:
Please check my comments on `CheckpointCoordinator` about preventing
duplicated codes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
