carp84 commented on a change in pull request #8617:
[FLINK-12619][StateBackend]Support TERMINATE/SUSPEND Job with Checkpoint
URL: https://github.com/apache/flink/pull/8617#discussion_r290567687
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
##########
@@ -424,6 +424,27 @@ public boolean isShutdown() {
}
}
+ public CompletableFuture<CompletedCheckpoint>
triggerSynchronousCheckpoint(
Review comment:
It seems to me that we could reuse the existing codes of
`triggerSynchronousSavepoint`, adding a flag to indicate whether it's a
checkpoint or savepoint. The same applies to
`LegacyScheduler#stopWithCheckpoint`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
