KurtYoung commented on a change in pull request #8435:
[FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in
blink
URL: https://github.com/apache/flink/pull/8435#discussion_r290568068
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/calcite/FlinkTypeFactory.scala
##########
@@ -164,19 +188,19 @@ class FlinkTypeFactory(typeSystem: RelDataTypeSystem)
extends JavaTypeFactoryImp
* using FlinkTypeFactory
*
* @param fieldNames field names
- * @param fieldTypes field types, every element is Flink's
[[InternalType]]
+ * @param fieldTypes field types, every element is Flink's
[[LogicalType]]
* @param fieldNullables field nullable properties
* @return a struct type with the input fieldNames, input fieldTypes, and
system fields
*/
def buildLogicalRowType(
fieldNames: Seq[String],
- fieldTypes: Seq[InternalType],
+ fieldTypes: Seq[LogicalType],
fieldNullables: Seq[Boolean]): RelDataType = {
Review comment:
Duplicate nullable information, `LogicalType` already contains such
information. And i think `buildLogicalRowType` is also necessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
