KurtYoung commented on a change in pull request #8435:
[FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in
blink
URL: https://github.com/apache/flink/pull/8435#discussion_r290593795
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/calcite/FlinkTypeFactory.scala
##########
@@ -147,12 +171,12 @@ class FlinkTypeFactory(typeSystem: RelDataTypeSystem)
extends JavaTypeFactoryImp
* Creates a struct type with the input fieldNames and input fieldTypes
using FlinkTypeFactory
*
* @param fieldNames field names
- * @param fieldTypes field types, every element is Flink's [[InternalType]]
+ * @param fieldTypes field types, every element is Flink's [[LogicalType]]
* @return a struct type with the input fieldNames, input fieldTypes, and
system fields
*/
def buildLogicalRowType(
Review comment:
OMG, how the caller suppose to tell this difference just seeing these two
API?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
