JingsongLi commented on a change in pull request #8435:
[FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in
blink
URL: https://github.com/apache/flink/pull/8435#discussion_r290579108
##########
File path:
flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/functions/aggfunctions/AvgAggFunction.java
##########
@@ -47,7 +44,7 @@
private UnresolvedReferenceExpression sum = new
UnresolvedReferenceExpression("sum");
private UnresolvedReferenceExpression count = new
UnresolvedReferenceExpression("count");
- public abstract TypeInformation getSumType();
+ public abstract DataType getSumType();
Review comment:
Look at @twalthr 's response.
>The user should not be confronted to two different type stacks. That's why
the description in DataType calls it "hints", a user should always use
DataType. If he adds a hint where it is not appropriate, we just don't need to
use those hints.
In @wuchong 's first thread.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
