JingsongLi commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink URL: https://github.com/apache/flink/pull/8435#discussion_r290589983
########## File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/plan/schema/ArrayRelDataType.scala ########## @@ -18,7 +18,7 @@ package org.apache.flink.table.plan.schema -import org.apache.flink.table.`type`.ArrayType +import org.apache.flink.table.types.logical.ArrayType Review comment: Nice catch, Yes, Previously, the main purpose was to distinguish `BasicArrayTypeInfo`, `ObjectArrayTypeInfo`, `PojoTypeInfo`, `RowTypeInfo` and etc... Now the `LogicalType` are sql type. so I think we don't need `Array/Map/Multiset RelDataType`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
