dawidwys commented on a change in pull request #8581: [FLINK-12254][table]
Update value literals to new type system
URL: https://github.com/apache/flink/pull/8581#discussion_r290600216
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/plan/rules/logical/LogicalWindowAggregateRuleBase.scala
##########
@@ -183,22 +183,22 @@ abstract class
LogicalWindowAggregateRuleBase(description: String)
TumblingGroupWindow(
windowRef,
timeField,
- new ValueLiteralExpression(interval, INTERVAL_MILLIS))
+ new ValueLiteralExpression(interval,
fromLegacyInfoToDataType(INTERVAL_MILLIS)))
Review comment:
How about just use `DataTypes` explicitly?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
