dawidwys commented on a change in pull request #8581: [FLINK-12254][table]
Update value literals to new type system
URL: https://github.com/apache/flink/pull/8581#discussion_r290597071
##########
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/utils/LegacyTypeInfoDataTypeConverter.java
##########
@@ -56,25 +56,32 @@
/**
* Converter between {@link TypeInformation} and {@link DataType} that
reflects the behavior before
- * Flink 1.9. The conversion is a 1:1 mapping that allows back-and-forth
conversion.
+ * Flink 1.9. The conversion is a 1:1 mapping that allows back-and-forth
conversion. Note that nullability
+ * constraints might get lost during the back-and-forth conversion.
*
* <p>This converter only exists to still support deprecated methods that take
or return {@link TypeInformation}.
* Some methods will still support type information in the future, however,
the future type information
- * support will integrate nicer with the new type stack. This converter
reflects the old behavior that includes:
+ * support will integrate nicer with the new type stack.
*
- * <p>Use old {@code java.sql.*} time classes for time data types.
+ * <p>This converter reflects the old behavior that includes:
*
- * <p>Only support millisecond precision for timestamps or day-time intervals.
+ * <ul>
+ * <li>Use old {@code java.sql.*} time classes for time data types.</li>
*
- * <p>Do not support fractional seconds for the time type.
+ * <li>Only support millisecond precision for timestamps or day-time
intervals.</li>
*
- * <p>Let variable precision and scale for decimal types pass through the
planner.
+ * <li>Let variable precision and scale for decimal types pass through the
planner.</li>
*
- * <p>Let POJOs, case classes, and tuples pass through the planner.
+ * <li>Inconsistent nullability. Most types are nullable even though type
information does not support it.</li>
*
- * <p>Inconsistent nullability. Most types are nullable even though type
information does not support it.
+ * <li>Distinction between {@link BasicArrayTypeInfo} and {@link
ObjectArrayTypeInfo}.</li>
*
- * <p>Distinction between {@link BasicArrayTypeInfo} and {@link
ObjectArrayTypeInfo}.
+ * <li>Let POJOs, case classes, and tuples pass through the planner.</li>
+ *
+ * <li>Inconsistent nullability. Most types are nullable even though type
information does not support it.</li>
Review comment:
Duplicated item.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
