tillrohrmann commented on a change in pull request #8609:
[FLINK-12541][container][python] Add support for Python jobs in build script
URL: https://github.com/apache/flink/pull/8609#discussion_r290736695
##########
File path:
flink-container/src/main/java/org/apache/flink/container/entrypoint/ClassPathJobGraphRetriever.java
##########
@@ -73,27 +76,31 @@
@Nonnull JobID jobId,
@Nonnull SavepointRestoreSettings
savepointRestoreSettings,
@Nonnull String[] programArguments,
- @Nullable String jobClassName) {
- this(jobId, savepointRestoreSettings, programArguments,
jobClassName, JarsOnClassPath.INSTANCE);
+ @Nullable String jobEntryPointName,
+ @Nullable String jobPythonArtifacts) {
+ this(jobId, savepointRestoreSettings, programArguments,
jobEntryPointName, jobPythonArtifacts, JarsOnClassPath.INSTANCE);
Review comment:
Why do we need to touch the `ClassPathJobGraphRetriever` at all? This class
should not need to know about Python. Otherwise we need to add special casing
for all supported languages in the future. This does not seem right.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
