tillrohrmann commented on a change in pull request #8609:
[FLINK-12541][container][python] Add support for Python jobs in build script
URL: https://github.com/apache/flink/pull/8609#discussion_r290737906
##########
File path:
flink-container/src/main/java/org/apache/flink/container/entrypoint/StandaloneJobClusterConfigurationParserFactory.java
##########
@@ -45,12 +45,29 @@
static final JobID DEFAULT_JOB_ID = new JobID(0, 0);
- private static final Option JOB_CLASS_NAME_OPTION = Option.builder("j")
+ @Deprecated
+ private static final Option JOB_CLASS_NAME_OPTION = Option.builder("jc")
.longOpt("job-classname")
.required(false)
.hasArg(true)
.argName("job class name")
- .desc("Class name of the job to run.")
+ .desc("Class name of the job to run. (deprecated; use
job-entrypoint instead.)")
+ .build();
+
+ private static final Option JOB_ENTRYPOINT_NAME_OPTION =
Option.builder("j")
+ .longOpt("job-entrypoint")
+ .required(false)
+ .hasArg(true)
+ .argName("job entrypoint name")
+ .desc("Entrypoint name of the job to run.")
+ .build();
+
+ private static final Option JOB_PYTHON_ARTIFACTS_OPTION =
Option.builder("ja")
Review comment:
Why does this need to be handled by the `StandaloenJobClusterConfiguration`
and cannot be parsed by the `PythonDriver` program?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
