sunjincheng121 commented on a change in pull request #8474: 
[FLINK-12409][python] Adds from_elements in TableEnvironment
URL: https://github.com/apache/flink/pull/8474#discussion_r291015294
 
 

 ##########
 File path: NOTICE-binary
 ##########
 @@ -5866,3 +5866,42 @@ This project bundles the following dependencies under 
the Apache Software Licens
 
 Apache HttpClient
 Copyright 1999-2017 The Apache Software Foundation
+
+// ------------------------------------------------------------------
+// NOTICE file corresponding to the section 4d of The Apache License,
+// Version 2.0, in this case for Apache Flink
+// ------------------------------------------------------------------
+
+Apache Flink
+Copyright 2006-2019 The Apache Software Foundation
+
+This product includes software developed at
+The Apache Software Foundation (http://www.apache.org/).
+
+flink-python
 
 Review comment:
   Thanks for point out this @zentol!
   In our ( @aljoscha and me ) plan, we want to remove the 
`flink-libraries/flink-python` later, currently, we add the classifier 
“java-binding”  for the JAR.  for the licensing I agree with you, we really 
have ambiguous licensing declarations here.  :( 
   We carefully thought about whether to change the module name, but the name 
flink-python is too apt, other names are not suitable, and the long-term goal 
we will remove the `flink-libraries/flink-python`. So we still want to use the 
name` flink-python`. So in order to eliminate ambiguity, can we add a little 
explanation in licensing? Or do you have better suggestions? 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to