sunjincheng121 commented on a change in pull request #8474: [FLINK-12409][python] Adds from_elements in TableEnvironment URL: https://github.com/apache/flink/pull/8474#discussion_r291846233
########## File path: NOTICE-binary ########## @@ -5866,3 +5866,42 @@ This project bundles the following dependencies under the Apache Software Licens Apache HttpClient Copyright 1999-2017 The Apache Software Foundation + +// ------------------------------------------------------------------ +// NOTICE file corresponding to the section 4d of The Apache License, +// Version 2.0, in this case for Apache Flink +// ------------------------------------------------------------------ + +Apache Flink +Copyright 2006-2019 The Apache Software Foundation + +This product includes software developed at +The Apache Software Foundation (http://www.apache.org/). + +flink-python Review comment: Currently, the names of modules in flink is `flink-language` patterns, such as `flink-java`, `flink-scala`. for the goal of `flink-python` will add `user-defined-functions` support in the next release, for UDFs we will add `data-service`, `state-service`...etc. And it's not only the API level. These functions need to be integrated with the beam. The code inside flink will not be very much, so the current plan is to distinguish these codes with packages or folder(for python). So, If we should not re-using artifactId, how about using `flink-py`. @zentol @aljoscha BTW: I appreciate if we can discuss this module name issue in the [[DISCUSS] FLIP-38 Support python language in flink Table API](https://docs.google.com/document/d/1ybYt-0xWRMa1Yf5VsuqGRtOfJBz4p74ZmDxZYg3j_h8/edit?usp=sharing): https://docs.google.com/document/d/1ybYt-0xWRMa1Yf5VsuqGRtOfJBz4p74ZmDxZYg3j_h8/edit?usp=sharing ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
