zhijiangW opened a new pull request #8648: [FLINK-12738][network] Remove abstract getPageSize method from InputGate URL: https://github.com/apache/flink/pull/8648 ## What is the purpose of the change *Currently `InputGate#getPageSize` is only used for constructing `BarrierBuffer`. In order to make abstract `InputGate` simple and clean, we should remove unnecessary abstract methods from it. Considering the page size could be parsed directly from configuration which could also visible while constructing `BarrierBuffer`, so it is reasonable to do so.* ## Brief change log - *Remove the parameter of page size from `CachedBufferBlocker` constructor* - *Refactor `getPageSize` utility from `NetworkEnvironmentConfiguration` to `ConfigurationParserUtils`* - *Remove `getPageSize` method from `InputGate`* - *Remove `getMemorySegmentSize` method from `BufferProvider` interface* - *Remove unnecessary `getMemorySegmentSize` method from `NetworkBufferPool`* ## Verifying this change *Covered by existing tests* ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no) - The serializers: (no) - The runtime per-record code paths (performance sensitive): (no) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no) - The S3 file system connector: (no) ## Documentation - Does this pull request introduce a new feature? (no) - If yes, how is the feature documented? (not applicable)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
