tillrohrmann commented on a change in pull request #8608:
[FLINK-11392][network] Introduce ShuffleEnvironment interface
URL: https://github.com/apache/flink/pull/8608#discussion_r291113844
##########
File path:
flink-core/src/main/java/org/apache/flink/configuration/NettyShuffleEnvironmentOptions.java
##########
@@ -29,7 +29,7 @@
*/
@PublicEvolving
@ConfigGroups(groups = @ConfigGroup(name = "NetworkNetty", keyPrefix =
"taskmanager.network.netty"))
-public class NetworkEnvironmentOptions {
+public class NettyShuffleEnvironmentOptions {
Review comment:
Is this renaming strictly necessary? If yes, then we need to add a release
not that this class has been renamed since it's `PublicEvolving`. What we could
also do is to add `class NetworkEnvironmentOptions extends
NettyShuffleEnvironmentOptions` and deprecate this class. That way it would not
break backwards compatibility.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
