tillrohrmann commented on a change in pull request #8608:
[FLINK-11392][network] Introduce ShuffleEnvironment interface
URL: https://github.com/apache/flink/pull/8608#discussion_r291186654
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerServices.java
##########
@@ -221,22 +222,27 @@ public void shutDown() throws FlinkException {
/**
* Creates and returns the task manager services.
*
+ * @param configuration Flink configuration.
* @param taskManagerServicesConfiguration task manager configuration
* @param taskManagerMetricGroup metric group of the task manager
* @param resourceID resource ID of the task manager
* @param taskIOExecutor executor for async IO operations
* @param freeHeapMemoryWithDefrag an estimate of the size of the free
heap memory
* @param maxJvmHeapMemory the maximum JVM heap size
+ * @param localCommunicationOnly True, to skip initializing the network
stack.
+ * Use only in cases where only one task
manager runs.
* @return task manager components
* @throws Exception
*/
public static TaskManagerServices fromConfiguration(
+ Configuration configuration,
Review comment:
Can't we pass in the `Configuration` as part of the
`TaskManagerServicesConfiguration`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
