[ 
https://issues.apache.org/jira/browse/FLINK-2622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14742768#comment-14742768
 ] 

ASF GitHub Bot commented on FLINK-2622:
---------------------------------------

Github user HuangWHWHW commented on the pull request:

    https://github.com/apache/flink/pull/1098#issuecomment-139933029
  
    `I still cannot understand what is the purpose of adding javaSet to the 
Table API. We can get the DataSet by using toDataSet method.`
    
    @fhueske 
    @chiwanpark 
    Hi, don't think too complicated.
    This is just about the compile error for the Table API tests since I added 
the `def writeAsText( filePath: String, writeMode: FileSystem.WriteMode = 
null): DataSink[T]` method in `DataStream.scala`.
    For easy understanding, you can also take a experiment that add the method 
and you will get some errors in these Table API tests.
    To add the `javaSet` just a way that I can pass these tests and I'm not 
sure this change is suitable.
    If not, how can I do?
    Refactor Table API in a new JIRA or here?


> Scala DataStream API does not have writeAsText method which supports WriteMode
> ------------------------------------------------------------------------------
>
>                 Key: FLINK-2622
>                 URL: https://issues.apache.org/jira/browse/FLINK-2622
>             Project: Flink
>          Issue Type: Bug
>          Components: Scala API, Streaming
>            Reporter: Till Rohrmann
>
> The Scala DataStream API, unlike the Java DataStream API, does not support a 
> {{writeAsText}} method which takes the {{WriteMode}} as a parameter. In order 
> to make the two APIs consistent, it should be added to the Scala DataStream 
> API.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to