dianfu commented on a change in pull request #8675: [FLINK-12716][python] Add
an interactive shell for Python Table API
URL: https://github.com/apache/flink/pull/8675#discussion_r291994588
##########
File path: flink-dist/src/main/flink-bin/bin/pyflink-gateway-server.sh
##########
@@ -67,4 +67,16 @@ if [[ -n "$FLINK_TESTING" ]]; then
done < <(find "$FLINK_SOURCE_ROOT_DIR" ! -type d \( -name
'flink-*-tests.jar' -o -path
"${FLINK_SOURCE_ROOT_DIR}/flink-connectors/flink-connector-elasticsearch-base/target/flink*.jar"
-o -path
"${FLINK_SOURCE_ROOT_DIR}/flink-connectors/flink-connector-kafka-base/target/flink*.jar"
\) -print0 | sort -z)
fi
-exec $JAVA_RUN $JVM_ARGS "${log_setting[@]}" -cp
${FLINK_CLASSPATH}:${TABLE_JAR_PATH}:${PYTHON_JAR_PATH}:${FLINK_TEST_CLASSPATH}
${DRIVER} ${ARGS[@]}
+COUNT=${#ARGS[@]}
+if [[ ${ARGS[0]} == "local" ]]; then
+ ARGS=("${ARGS[@]:1:$COUNT}")
+ COUNT=$((COUNT-1))
+ if [[ COUNT -gt 1 ]] && [[ ${ARGS[0]} == "-a" ]]; then
+ EXTERAL_CLASSPATH=${ARGS[1]}
+ ARGS=("${ARGS[@]:2:$COUNT}")
+ fi
+ exec $JAVA_RUN $JVM_ARGS "${log_setting[@]}" -cp
${FLINK_CLASSPATH}:${TABLE_JAR_PATH}:${PYTHON_JAR_PATH}:${FLINK_TEST_CLASSPATH}:${EXTERAL_CLASSPATH}
${DRIVER} ${ARGS[@]}
+else
+ ARGS=("${ARGS[@]:1:$COUNT}")
+ exec "$FLINK_BIN_DIR"/flink run ${ARGS[@]} -c ${DRIVER} -a
${PYTHON_JAR_PATH} -j ${TABLE_JAR_PATH}
Review comment:
What about removing the option `-a`?
We can set the `isPython` to true if the entrypoint class is
"PythonGatewayServer" in `ProgramOptions`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
