dianfu commented on a change in pull request #8675: [FLINK-12716][python] Add
an interactive shell for Python Table API
URL: https://github.com/apache/flink/pull/8675#discussion_r292726089
##########
File path:
flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java
##########
@@ -774,22 +774,24 @@ PackagedProgram buildProgram(ProgramOptions options)
throws FileNotFoundExceptio
String jarFilePath = options.getJarFilePath();
List<URL> classpaths = options.getClasspaths();
- String entryPointClass;
+ // Get assembler class
+ String entryPointClass = options.getEntryPointClassName();
File jarFile = null;
if (options.isPython()) {
// If the job is specified a jar file
if (jarFilePath != null) {
jarFile = getJarFile(jarFilePath);
}
- // The entry point class of python job is PythonDriver
- entryPointClass =
"org.apache.flink.python.client.PythonDriver";
+ // If the job is Python Shell job, the entry point
class name is PythonGateWayServer.
+ // Otherwise, the entry point class of python job is
PythonDriver
+ if (options.getEntryPointClassName() == null) {
Review comment:
if (entryPointClass == null)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
