JingsongLi commented on issue #8689: [FLINK-12802][table-runtime-blink] Reducing the Code of BinaryString URL: https://github.com/apache/flink/pull/8689#issuecomment-501093166 > I haven't go through the changes, but one thing comes to my mind, which is we can follow jdk String's interfaces. If `String` has such interface, we can also keep it in `BinaryString`. If not, we can put it in `BinaryStringUtil`. Yeah, Now keep below interface in BinaryString: 1.numChars: We can't call it length, because it's easy to misunderstand with byteLength. 2.byteAt: something like charAt in JDK String 3.copy: copy a new BinaryString, it is useful. 4.getBytes, equals, toString, compareTo, substring, contains, startsWith, endsWith, trim, indexOf, toUpperCase, toLowerCase: keep same to JDK String.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
