tillrohrmann commented on a change in pull request #8680: [FLINK-12706]
Introduce ShuffleService interface and its configuration
URL: https://github.com/apache/flink/pull/8680#discussion_r293332170
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java
##########
@@ -170,6 +171,8 @@
private final Map<ResourceID, Tuple2<TaskManagerLocation,
TaskExecutorGateway>> registeredTaskManagers;
+ private final ShuffleMaster<?> shuffleMaster;
Review comment:
Why do we store the `ShuffleMaster` here? Wouldn't it be enough to pass it
on to the `createScheduler` method?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
