tillrohrmann commented on a change in pull request #8680: [FLINK-12706]
Introduce ShuffleService interface and its configuration
URL: https://github.com/apache/flink/pull/8680#discussion_r293302963
##########
File path:
flink-core/src/main/java/org/apache/flink/configuration/CoreOptions.java
##########
@@ -306,4 +306,17 @@
public static ConfigOption<Long>
fileSystemConnectionLimitStreamInactivityTimeout(String scheme) {
return ConfigOptions.key("fs." + scheme +
".limit.stream-timeout").defaultValue(0L);
}
+
+ //
------------------------------------------------------------------------
+ // shuffle service
+ //
------------------------------------------------------------------------
+
+ /**
+ * The shuffle service implementation class full name.
+ */
+ public static final ConfigOption<String> SHUFFLE_SERVICE = ConfigOptions
Review comment:
On the one hand, it would not hurt to put it into the `flink-runtime` module
because it should be a cluster only option and thus not needed in an API
module. On the other hand we also put the `NettyShuffleEnvironmentOptions` and
`HistoryServerOptions` into `flink-core`. Thus, one could argue that the
current placement is in line with the other options.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
