HuangXingBo commented on a change in pull request #8675: [FLINK-12716][python] Add an interactive shell for Python Table API URL: https://github.com/apache/flink/pull/8675#discussion_r293689233
########## File path: flink-dist/src/main/flink-bin/bin/pyflink-shell.sh ########## @@ -0,0 +1,79 @@ +#!/bin/bash Review comment: IMO, a script with prefix 'start-' means that it will be in a background process and the script will hava a corresponding stop script just like start-cluster.sh and stop-cluster.sh.What do you think? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
