pnowojski commented on a change in pull request #8731: [FLINK-11878][runtime] 
Implement the runtime handling of BoundedOneInput and BoundedMultiInput
URL: https://github.com/apache/flink/pull/8731#discussion_r293729235
 
 

 ##########
 File path: 
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/SourceStreamTaskTest.java
 ##########
 @@ -291,5 +325,34 @@ public void run(SourceContext<String> ctx) throws 
Exception {
                @Override
                public void cancel() {}
        }
+
+       private static class TestBoundedSource implements 
SourceFunction<String> {
 
 Review comment:
   I'm pretty sure there is already something like that defined somewhere. For 
example:
   
`org.apache.flink.test.streaming.runtime.StreamTaskSelectiveReadingITCase.TestStringSource`
   `org.apache.flink.streaming.runtime.tasks.SourceStreamTaskTest.MockSource`
   or even production class
   `org.apache.flink.streaming.api.functions.source.FromElementsFunction`
   
   Please re-use one of them, preferably `FromElementsFunction`.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to