pnowojski commented on a change in pull request #8731: [FLINK-11878][runtime]
Implement the runtime handling of BoundedOneInput and BoundedMultiInput
URL: https://github.com/apache/flink/pull/8731#discussion_r295240204
##########
File path:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/StreamSourceOperatorLatencyMetricsTest.java
##########
@@ -163,7 +164,7 @@ private void testLatencyMarkEmission(int
numberLatencyMarkers, OperatorSetupOper
operatorSetup.setupSourceOperator(operator,
testProcessingTimeService);
// run and wait to be stopped
- operator.run(new Object(), mock(StreamStatusMaintainer.class),
new CollectorOutput<Long>(output));
+ operator.run(new Object(), mock(StreamStatusMaintainer.class),
new CollectorOutput<Long>(output), mock(OperatorChain.class));
Review comment:
Please do not introduce new mockito mocked classes. As usually either:
- please instantiate a real `OpeartorChain`
- please instantiate a real `OpeartorChain` with maybe mocked content
`RecordWriters `
- implement `OperatorChain` mock, maybe a `NoOpOperatorChain`
Keep in mind that `mocked` I mean a proper mocks, not mockito.
(You can read about the reasoning behind not using mockito in the proposed
code style guideline)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
