azagrebin commented on a change in pull request #7757: [FLINK-11630] Triggers
the termination of all running Tasks when shutting down TaskExecutor
URL: https://github.com/apache/flink/pull/7757#discussion_r294389031
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java
##########
@@ -178,6 +179,8 @@
/** The kvState registration service in the task manager. */
private final KvStateService kvStateService;
+ private final List<Task> submittedTasks;
Review comment:
At this point, I would introduce a new class `TaskCompletionTracker` which
keeps `submittedTasks` and has 2 methods: `trackTaskCompletion(Task task)`
called from `submitTask` and `failIncompleteTasksAndWaitForAllCompleted()`
which would return `FutureUtils.waitForAll(failSubmittedTasks())`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
