azagrebin commented on a change in pull request #7757: [FLINK-11630] Triggers
the termination of all running Tasks when shutting down TaskExecutor
URL: https://github.com/apache/flink/pull/7757#discussion_r294381913
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java
##########
@@ -566,6 +592,7 @@ private void stopTaskExecutorServices() throws Exception {
}
if (taskAdded) {
+ submittedTasks.add(task);
Review comment:
We should also schedule a callback to
`task.getTaskCompletionFuture().thenRun(() ->
submittedTasks.remove(tdd.getExecutionAttemptId()))` if `submittedTasks` is
e.g. a `ConcurrentHashMap<ExecutionAttemptID, Task>`. Otherwise tasks keep
piling in memory for this `TaskExecutor` for the cluster lifetime.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
