gaoyunhaii commented on a change in pull request #8740: [FLINK-12763][runtime]
Fail job immediately if tasks’ resource needs can not be satisfied.
URL: https://github.com/apache/flink/pull/8740#discussion_r294566905
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java
##########
@@ -133,7 +139,7 @@
private final FatalErrorHandler fatalErrorHandler;
/** The slot manager maintains the available slots. */
- private final SlotManager slotManager;
+ protected final SlotManager slotManager;
Review comment:
I think it may be better to have a protected
`setAllowedSlotResourceProfiles` method in the ResourceManager than making
`slotManager` to be protected directly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
