gaoyunhaii commented on a change in pull request #8740: [FLINK-12763][runtime]
Fail job immediately if tasks’ resource needs can not be satisfied.
URL: https://github.com/apache/flink/pull/8740#discussion_r294568899
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManager.java
##########
@@ -123,6 +125,9 @@
/** Release task executor only when each produced result partition is
either consumed or failed. */
private final boolean waitResultConsumedBeforeRelease;
+ /** Resource profiles of slots that can be acquired. */
+ private final HashSet<ResourceProfile> allowedSlotResourceProfiles =
new HashSet<>();
Review comment:
I think the name is a little ambiguous and it seems to be the resource
profiles of the slots that are allowed to created on the TM side. I think it
may be better to use names like `availableSlotResourceProfiles`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
