godfreyhe commented on a change in pull request #8707: [FLINK-12815] [table-planner-blink] Supports CatalogManager in blink planner URL: https://github.com/apache/flink/pull/8707#discussion_r294587149
########## File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/descriptors/OldCsv.scala ########## @@ -0,0 +1,200 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.descriptors + +import java.util + +import org.apache.flink.api.common.typeinfo.TypeInformation +import org.apache.flink.table.api.{TableSchema, ValidationException} +import org.apache.flink.table.descriptors.OldCsvValidator._ +import org.apache.flink.table.utils.TypeStringUtils + +import scala.collection.mutable +import scala.collection.JavaConverters._ + +/** + * Format descriptor for comma-separated values (CSV). + * + * Note: This descriptor describes Flink's non-standard CSV table source/sink. In the future, the + * descriptor will be replaced by a proper RFC-compliant version. Use the RFC-compliant `Csv` + * format in the dedicated `flink-formats/flink-csv` module instead when writing to Kafka. Use the + * old one for stream/batch filesystem operations for now. + * + * @deprecated Use the RFC-compliant `Csv` format in the dedicated + * `flink-formats/flink-csv` module instead when writing to Kafka. + */ +@Deprecated +@deprecated Review comment: `Deprecated` is for java, and `deprecated` is for scala. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
