xuefuz commented on a change in pull request #8769: [FLINK-12875][hive] support
converting input args of char, varchar, bytes, timestamp, date for Hive
functions
URL: https://github.com/apache/flink/pull/8769#discussion_r294601901
##########
File path:
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/functions/hive/conversion/HiveInspectors.java
##########
@@ -162,34 +220,64 @@ public static Object toFlinkObject(ObjectInspector
inspector, Object data) {
return oi.preferWritable() ?
oi.get(data) :
- oi.getPrimitiveWritableObject(data);
+ oi.getPrimitiveJavaObject(data);
Review comment:
I'm not sure if we need to call oi.preferWritable() because we are
converting Hive data to Flink data. Flink is always expecting java object.
Thus, oi.getPrimitiveJavaObject() might be enough. I'm not 100% sure, though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
