xuefuz commented on a change in pull request #8769: [FLINK-12875][hive] support converting input args of char, varchar, bytes, timestamp, date for Hive functions URL: https://github.com/apache/flink/pull/8769#discussion_r294987573
########## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/functions/hive/conversion/HiveInspectors.java ########## @@ -119,9 +141,45 @@ public static HiveObjectConversion getConversion(ObjectInspector inspector) { } else { return IdentityConversion.INSTANCE; } + } else if (inspector instanceof JavaDateObjectInspector) { + if (((JavaDateObjectInspector) inspector).preferWritable()) { Review comment: okay. you're probably right. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services