liyafan82 commented on a change in pull request #8689:
[FLINK-12802][table-runtime-blink] Reducing the Code of BinaryString
URL: https://github.com/apache/flink/pull/8689#discussion_r294617113
##########
File path:
flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/dataformat/BinaryString.java
##########
@@ -79,13 +81,19 @@ public static BinaryString fromString(String str) {
}
}
+ /**
+ * Creates an BinaryString from given UTF-8 bytes.
+ */
public static BinaryString fromBytes(byte[] bytes) {
return fromBytes(bytes, 0, bytes.length);
}
+ /**
+ * Creates an BinaryString from given UTF-8 bytes with offset and
numBytes.
Review comment:
numBytes -> number of bytes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
