liyafan82 commented on a change in pull request #8689:
[FLINK-12802][table-runtime-blink] Reducing the Code of BinaryString
URL: https://github.com/apache/flink/pull/8689#discussion_r294617538
##########
File path:
flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/dataformat/BinaryString.java
##########
@@ -170,12 +160,8 @@ public byte getByte(int i) {
}
}
- private byte getByteOneSegment(int i) {
- return segments[0].get(offset + i);
- }
-
/**
- * Get the underlying byte array, the returned bytes maybe reused.
+ * Get the underlying UTF-8 byte array, the returned bytes maybe reused.
Review comment:
maybe -> may be
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
