[ 
https://issues.apache.org/jira/browse/FLINK-12881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Xu Yang updated FLINK-12881:
----------------------------
    Description: 
1. change Params$get to support aliases
*  support aliases
*  if the Params contains the specific parameter and alias, but has more than 
one value or
*  if the Params doesn't contains the specific parameter, while the ParamInfo 
is optional but has no default value. when isOptional is true, 
contain(ParamInfo) is true, it will return the value found in Params, whether 
the value is null or not. when isOptional is true, contain(ParamInfo) is false: 
hasDefaultValue is true, it will return defaultValue. hasDefaultValue is false, 
it will throw exception. developer should use contain to check that Params has 
ParamInfo or not.

2.  add size, clear, isEmpty, contains, fromJson in Params
3.  fix ParamInfo, PipelineStage to adapt new Params
     * assert null in alias
     * use Params$loadJson in PipelineStage

4.  add test cases about aliases

  was:
# change Params$get to support aliases
*  support aliases
*  if the Params contains the specific parameter and alias, but has more than 
one value or
*  if the Params doesn't contains the specific parameter, while the ParamInfo 
is optional but has no default value
 when isOptional is true, contain(ParamInfo) is true, it will return the value 
found in Params, whether the value is null or not. when isOptional is true, 
contain(ParamInfo) is false: hasDefaultValue is true, it will return 
defaultValue. hasDefaultValue is false, it will throw exception. developer 
should use contain to check that Params has ParamInfo or not.
#  add size, clear, isEmpty, contains, fromJson in Params
#  fix ParamInfo, PipelineStage to adapt new Params
#  add test cases about aliases


> Add more functionalities for ML Params and ParamInfo class
> ----------------------------------------------------------
>
>                 Key: FLINK-12881
>                 URL: https://issues.apache.org/jira/browse/FLINK-12881
>             Project: Flink
>          Issue Type: Sub-task
>            Reporter: Xu Yang
>            Assignee: Xu Yang
>            Priority: Major
>
> 1. change Params$get to support aliases
> *  support aliases
> *  if the Params contains the specific parameter and alias, but has more than 
> one value or
> *  if the Params doesn't contains the specific parameter, while the ParamInfo 
> is optional but has no default value. when isOptional is true, 
> contain(ParamInfo) is true, it will return the value found in Params, whether 
> the value is null or not. when isOptional is true, contain(ParamInfo) is 
> false: hasDefaultValue is true, it will return defaultValue. hasDefaultValue 
> is false, it will throw exception. developer should use contain to check that 
> Params has ParamInfo or not.
> 2.  add size, clear, isEmpty, contains, fromJson in Params
> 3.  fix ParamInfo, PipelineStage to adapt new Params
>      * assert null in alias
>      * use Params$loadJson in PipelineStage
> 4.  add test cases about aliases



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to