xuefuz commented on a change in pull request #8784: [FLINK-12892][table][hive]
serialize catalog table to properties for table discovery service
URL: https://github.com/apache/flink/pull/8784#discussion_r294998709
##########
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/descriptors/DescriptorProperties.java
##########
@@ -103,6 +103,18 @@ public void putProperties(DescriptorProperties
otherProperties) {
}
}
+ /**
+ * Adds a properties map by appending the given prefix to element keys.
+ */
+ public void putPropertiesWithPrefix(String prefix, Map<String, String>
prop) {
Review comment:
Maybe the '.' should be part of the prefix rather than being hardcoded here.
Doing this should simplify both doc and code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
