xuefuz commented on a change in pull request #8784: [FLINK-12892][table][hive]
serialize catalog table to properties for table discovery service
URL: https://github.com/apache/flink/pull/8784#discussion_r295001595
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/GenericCatalogTable.java
##########
@@ -53,13 +53,6 @@ public GenericCatalogTable copy() {
getSchema().copy(), new
ArrayList<>(getPartitionKeys()), new HashMap<>(getProperties()), getComment());
}
- @Override
- public Map<String, String> toProperties() {
- // TODO: Filter out ANY properties that are not needed for
table discovery.
Review comment:
Here TODO item says that we need to filter out any properties that are not
needed for table factory discovery. One example that I can think of is
GenericInMemoryCatalog.FLINK_IS_GENERIC_KEY.
I also remember that we prefixed some properties before storing them in HMS.
Should we remove the prefix in toProperties()?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
